Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(preview_instance.yaml): Fix typo in file name #7039

Merged
merged 1 commit into from
Dec 31, 2023
Merged

fix(preview_instance.yaml): Fix typo in file name #7039

merged 1 commit into from
Dec 31, 2023

Conversation

roydahan
Copy link
Contributor

Replace "-" with "_".

Testing

  • [ ]

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Reminders

  • Add New configuration option and document them (in sdcm/sct_config.py)
  • Add unit tests to cover my changes (under unit-test/ folder)
  • Update the Readme/doc folder relevent to this change (if needed)

@roydahan roydahan requested a review from fruch December 31, 2023 14:23
@fruch fruch added backport/5.4 Need backport to 5.4 backport/2024.1 Need backport to 2024.1 labels Dec 31, 2023
fruch
fruch approved these changes Dec 31, 2023
View reviewed changes
Copy link
Contributor

@fruch fruch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fruch fruch merged commit 1fcdd68 into scylladb:master Dec 31, 2023
4 of 6 checks passed
@fruch fruch added backport/2024.1-done Commit backported to 2024.1 backport/5.4-done Commit backported to 5.4 labels Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fruch fruch fruch approved these changes

Assignees

@roydahan roydahan

Labels
backport/5.4-done Commit backported to 5.4 backport/5.4 Need backport to 5.4 backport/2024.1-done Commit backported to 2024.1 backport/2024.1 Need backport to 2024.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roydahan @fruch